[openstreetmap/openstreetmap-website] Rework the users#show page to avoid custom column css (#2697)

Andy Allan notifications at github.com
Wed Jul 8 15:05:57 UTC 2020


This uses bootstrap instead, ensuring the map shows before the text on small screens, but to the right of it on md+ widths. The height of the map also changes at this breakpoint instead of being based on the menu width (body.small).

The account edit page was also changed to match the content_map changes, and a full width map is now used. This can be changed, if required, using bootstrap breakpoints but I like it as it is.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2697

-- Commit Summary --

  * Rework the users#show page to avoid custom column css

-- File Changes --

    M app/assets/stylesheets/common.scss (31)
    M app/assets/stylesheets/small.scss (13)
    M app/views/users/account.html.erb (2)
    M app/views/users/show.html.erb (104)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2697.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2697.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2697
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200708/6f6797ce/attachment-0001.htm>


More information about the rails-dev mailing list