[openstreetmap/openstreetmap-website] Avoid testing against empty db queries (#2725)

Andy Allan notifications at github.com
Wed Jul 22 15:43:16 UTC 2020


This PR fixes #2614. Minor refactoring of tests to create relevant objects, and test against them. Previously these tests were asserting against empty database queries, since the fixtures were removed a few years ago.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2725

-- Commit Summary --

  * Refator way_full test to avoid relying on non-existant fixtures
  * Refactor changeset index testing to assert against objects, not db queries

-- File Changes --

    M test/controllers/api/ways_controller_test.rb (44)
    M test/controllers/changesets_controller_test.rb (44)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2725.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2725.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2725
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200722/80a31b01/attachment-0001.htm>


More information about the rails-dev mailing list