[openstreetmap/openstreetmap-website] Request wikidata and osm sophox to linkify some tag value (#2621)

Andy Allan notifications at github.com
Wed Jun 3 13:31:15 UTC 2020


> The code is mostly finished and ready for review.

I've reviewed the code today, and my only suggestions are:

* I would prefer to see the update script as a rake task, and have the target file hardcoded, to make it easier to find and run in the future. 

But these are just a suggestions, not required for merging. I don't have any other comments.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2621#issuecomment-638198437
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200603/2e892720/attachment.htm>


More information about the rails-dev mailing list