[openstreetmap/openstreetmap-website] WIP: simple_form (#2655)

Tom Hughes notifications at github.com
Thu Jun 11 11:25:14 UTC 2020


@tomhughes commented on this pull request.

Looks like a good start to me...

The initializers, especially the bootstrap one, are a little disturbing ;-)

> @@ -0,0 +1,15 @@
+<%# frozen_string_literal: true %>

Is this actually used by anything?

> @@ -116,6 +117,20 @@ en:
       # html: '<abbr title="required">*</abbr>'
     error_notification:
       default_message: "Please review the problems below:"
+    hints:
+      trace:
+        tagstring: comma delimited
+    labels:
+      trace:
+        gpx_file: Upload GPX File
+        visibility: Visibility
+    options:
+      trace:
+        visibility:
+          private: Private (only shared as anonymous, unordered points)
+          public: Public (shown in trace list and as anonymous, unordered points)
+          trackable: Trackable (only shared as anonymous, ordered points with timestamps)
+          identifiable: Identifiable (shown in trace list and as identifiable, ordered points with timestamps)

With these descriptions moved here do we still need the old ones?

> -    </div>
-    <div class='standard-form-row'>
-      <label class='standard-label'><%= t ".tags" %></label>
-      <%= f.text_field :tagstring %> (<%= t ".tags_help" %>)
-    </div>
-    <div class='standard-form-row'>
-      <label class='standard-label'><%= t ".visibility" %></label>
-      <%= f.select :visibility, [[t("traces.visibility.private"), "private"], [t("traces.visibility.public"), "public"], [t("traces.visibility.trackable"), "trackable"], [t("traces.visibility.identifiable"), "identifiable"]] %> (<a href="<%= t ".visibility_help_url" %>"><%= t ".visibility_help" %></a>)
-    </div>
-  </fieldset>
-
-</div>
-
-<%= f.submit %>
-
+<%= simple_form_for @trace do |f| %>

This seems to have lost all the extra information that was displayed before the editable fields - is that a deliberate decision?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2655#pullrequestreview-428808993
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200611/c4e019e2/attachment.htm>


More information about the rails-dev mailing list