[openstreetmap/openstreetmap-website] Changed open_note_marker from red 'X' to yellow '!' (#2946)
Andy Allan
notifications at github.com
Wed Nov 11 14:09:41 UTC 2020
@gravitystorm requested changes on this pull request.
Looks good! Can I ask for a few small changes:
* There is a file NoteMarker.svg in the same directory, which contains the SVG sources for the note markers. Could you please add your new marker to that file too, that way it's easier in future if more changes need to be made.
* Have you tried with a slightly more vibrant colour? I found this particular yellow hard to see when I tested it locally. The markers are translucent so the map background shines through - this means that markers need to be strongly coloured to really stand out.
* The .png files here are much much bigger (10x) than the originals. It looks like photoshop has added large amounts of metadata to the files. If you can remove that, great, but if not we'll do that ourselves. (e.g. `pngcrush -rem text open_note_marker.png test.png` reduces from 19170 to 2274 bytes, original was 1883).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2946#pullrequestreview-528203410
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201111/106aa73e/attachment.htm>
More information about the rails-dev
mailing list