[openstreetmap/openstreetmap-website] Add table borders for legibility in richtext diary posts (#2959)

[Andy Allan]

@gravitystorm requested changes on this pull request.

Thanks for the PR. I'm happy to see more styling being added to tables within diary entries and other places where we have our "richtext" content.

However, we need to change the approach used. We've moved to Bootstrap for most of our styling, and so we should not be adding more custom styling rules to common.scss any longer. Bootstrap gives us various table styling options (https://getbootstrap.com/docs/4.5/content/tables/) out of the box, and so we should use one of them.

Since bootstrap tables are opt-in, i.e. require a class to be added to the `<table>` tag, then that will need to be implemented as part of the RichText.to_html process (in [`lib/rich_text.rb`](https://github.com/openstreetmap/openstreetmap-website/blob/4e78f3ae5b0d96f599840e181c1a4be4335dded9/lib/rich_text.rb))



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2959#pullrequestreview-533597182
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201118/7838a71c/attachment.htm>