[openstreetmap/openstreetmap-website] Add a preferred_email_format preference (#1511)

[Andy Allan]

I've been reviewing this PR today, and there's a few things that prevent it from being in a mergeable state:

* Use of fixtures instead of factories
* Confusion over the terminology of 'multipart' vs 'html' in the preferences and code
* Details around the enums and fallbacks, as mentioned in reviews
* Requested changes to the compose_email function parameters (ideally to match the parameters sent to the regular `mail` method)

I also think the approach in the notifier is overly complex, since it requires a bunch of logic in the `compose_mail` function including flags for adding attachments, and I think there are better (less intrusive) ways of doing this.

However, I'm not planning on reworking this PR to address these issues, since I don't think the overall topic is important enough compared to our other issues. So I'm going to close this pull request. If someone else wants to spend time on reworking this PR, then I hope the above points help illustrate the changes that would be required.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1511#issuecomment-708368958
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201014/4eba8144/attachment.htm>