[openstreetmap/openstreetmap-website] Rename Notifier to UserMailer (#2884)

[Andy Allan]

It's a convention in rails to name your mailers with a Mailer suffix, and is also common to name the class after the recipient (e.g. User, Admin). So UserMailer seems a reasonable choice.

As an aside, I found https://katanacode.com/blog/ruby-on-rails-action-mailer-how-to-name-mailer-methods/ which is interesting and perhaps we could us as a convention for the method naming too. But I left those alone for now.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2884

-- Commit Summary --

  * Rename Notifier to UserMailer

-- File Changes --

    M .rubocop_todo.yml (10)
    M app/controllers/api/changeset_comments_controller.rb (2)
    M app/controllers/api/notes_controller.rb (2)
    M app/controllers/diary_entries_controller.rb (2)
    M app/controllers/friendships_controller.rb (2)
    M app/controllers/messages_controller.rb (2)
    M app/controllers/users_controller.rb (8)
    R app/helpers/user_mailer_helper.rb (2)
    M app/jobs/trace_importer_job.rb (6)
    R app/mailers/user_mailer.rb (28)
    D app/views/notifier/_gpx_description.html.erb (12)
    D app/views/notifier/email_confirm.html.erb (7)
    D app/views/notifier/email_confirm.text.erb (7)
    D app/views/notifier/gpx_failure.html.erb (16)
    D app/views/notifier/lost_password.html.erb (7)
    D app/views/notifier/lost_password.text.erb (7)
    A app/views/user_mailer/_gpx_description.html.erb (12)
    R app/views/user_mailer/_message_body.html.erb (0)
    R app/views/user_mailer/changeset_comment_notification.html.erb (0)
    R app/views/user_mailer/changeset_comment_notification.text.erb (0)
    R app/views/user_mailer/diary_comment_notification.html.erb (0)
    R app/views/user_mailer/diary_comment_notification.text.erb (0)
    A app/views/user_mailer/email_confirm.html.erb (7)
    A app/views/user_mailer/email_confirm.text.erb (7)
    R app/views/user_mailer/friendship_notification.html.erb (0)
    R app/views/user_mailer/friendship_notification.text.erb (0)
    A app/views/user_mailer/gpx_failure.html.erb (16)
    R app/views/user_mailer/gpx_success.html.erb (4)
    A app/views/user_mailer/lost_password.html.erb (7)
    A app/views/user_mailer/lost_password.text.erb (7)
    R app/views/user_mailer/message_notification.html.erb (0)
    R app/views/user_mailer/message_notification.text.erb (0)
    R app/views/user_mailer/note_comment_notification.html.erb (0)
    R app/views/user_mailer/note_comment_notification.text.erb (0)
    R app/views/user_mailer/signup_confirm.html.erb (0)
    R app/views/user_mailer/signup_confirm.text.erb (0)
    M config/locales/en.yml (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2884.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2884.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2884
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201014/68b7c3d2/attachment-0001.htm>