[openstreetmap/openstreetmap-website] Welcome message: fix display of 'close' button (#2872)

[Andy Allan]

Thanks for the PR, I reviewed it yesterday. This proposal is similar to #2537, and it has similar problems to #2537 , namely

* It introduces more custom CSS classes, which we're trying to remove
* It only addresses the welcome message, and not the other similar situations like the sidebar panels.

Based on some of the discussions on #2537 by @bezdna , I've started work on replacing the h2+close button by a flex-box based solution. This in particular addresses the point made about the close button not being related to the header itself (and so it shouldn't appear within the h2 element). I ran out of time this week before finishing it, but you can see what I'm thinking at https://github.com/gravitystorm/openstreetmap-website/commit/b3fc5bc71a4fd7a5b13aee3cad1c527de244da4e - feedback is welcome. I intend to use the same solution (maybe not the exact same partial, but at least the same divs and flexbox layout) for all of our current close buttons, so that they behave consistently.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2872#issuecomment-709367093
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201015/372d5faa/attachment.htm>