[openstreetmap/openstreetmap-website] Avoid various uses of html_safe (#2898)

Andy Allan notifications at github.com
Wed Oct 21 13:44:46 UTC 2020


We can avoid using `html_safe` in various circumstances, through alternative approaches like i18n keys ending in `_html` or using `safe_join` to avoid converting via unsafe string types.

The `_html` keys approach only work for ActionView helper version of `t`, not the base `I18n.t` method.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2898

-- Commit Summary --

  * Avoid various uses of html_safe

-- File Changes --

    M .rubocop_todo.yml (2)
    M app/controllers/users_controller.rb (2)
    M app/helpers/note_helper.rb (16)
    M app/helpers/open_graph_helper.rb (4)
    M app/views/browse/changeset.html.erb (8)
    M config/locales/en.yml (24)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2898.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2898.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2898
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201021/530edda7/attachment.htm>


More information about the rails-dev mailing list