[openstreetmap/openstreetmap-website] Improve the OAuth index page (#2889)

[Andy Allan]

@gravitystorm requested changes on this pull request.



> @@ -15,7 +15,7 @@
   </thead>
   <% @tokens.each do |token| %>
     <tr>
-      <td><%= link_to token.client_application.name, token.client_application.url %></td>
+      <td><%= link_to token.client_application.name, token.client_application.url, target: "_blank" %></td>

We rarely use `target: "_blank"` for links - any particular reason to add it to this one?

Also this line causes the CI failures for both hash rocket syntax, and noopener when using target: "_blank"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2889#pullrequestreview-513740696
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201021/b0885e61/attachment.htm>