[openstreetmap/openstreetmap-website] Use flexbox to position the close icon on the sidebars (#2901)

Andy Allan notifications at github.com
Wed Oct 21 15:25:16 UTC 2020


This ensures that the text and the close icon don't overlap, regardless of the length of the title. The title div grows to use all available space, while ensuring the text breaks if necessary to prevent it from pushing the close icon offscreen.

* Fixes #2530 #2850 
* Alternative to #2537 #2872
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2901

-- Commit Summary --

  * Use flexbox to position the close icon on the sidebars

-- File Changes --

    A app/views/application/_sidebar_header.html.erb (10)
    M app/views/browse/changeset.html.erb (5)
    M app/views/browse/feature.html.erb (5)
    M app/views/browse/history.html.erb (5)
    M app/views/browse/new_note.html.erb (5)
    M app/views/browse/not_found.html.erb (11)
    M app/views/browse/note.html.erb (5)
    M app/views/browse/query.html.erb (5)
    M app/views/browse/timeout.html.erb (7)
    M app/views/changesets/history.html.erb (5)
    M app/views/geocoder/search.html.erb (6)
    M app/views/layouts/map.html.erb (3)
    M app/views/site/export.html.erb (5)
    M config/locales/en.yml (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2901.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2901.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2901
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201021/d22e6937/attachment.htm>


More information about the rails-dev mailing list