[openstreetmap/openstreetmap-website] Improve the OAuth index page (#2889)

Hidde Wieringa notifications at github.com
Sun Oct 25 13:23:34 UTC 2020


@hiddewie commented on this pull request.



> @@ -15,7 +15,7 @@
   </thead>
   <% @tokens.each do |token| %>
     <tr>
-      <td><%= link_to token.client_application.name, token.client_application.url %></td>
+      <td><%= link_to token.client_application.name, token.client_application.url, target: "_blank" %></td>

I would argue that any link that does not remain in the current application should be opened in a new tab. This makes users less likely to lose their way if they click on the OAuth application name. There are many more external links which should maybe also be opened in a new tab. It would be even better to annotate them with an icon like below to notify users of such links.

![image](https://user-images.githubusercontent.com/1073881/97108386-8cb96880-16cd-11eb-9e3d-5b3ea7c940c3.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2889#discussion_r511596780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201025/69e3911f/attachment.htm>


More information about the rails-dev mailing list