[openstreetmap/openstreetmap-website] Split User settings into different forms? (#3167)

[Andy Allan]

We currently have one big form for many things a user can change, including:

* Passwords and email addresses
* Profile description and avatar
* Preferred language and editor
* Home location

In my mind, these cover too many disparate things, and the page suffers from complexity both for the user and also for the developers (e.g. have a look at users_controller and see what goes on when you press save).

I think we should split this form up. My first instinct is to separate out things that are public (avatar, profile information, home location) from things that are private (email address, password, etc), and have "Edit Profile" and "Edit Settings" as two distinct forms. This will allow us to explain to users more clearly that certain settings are public information, even if they don't realise it (like home location).

But that still leaves two problems, firstly that the remaining settings are still a bit of a grab-bag between 'account' settings like email / password, and things that are more like 'preferences' such as language and preferred editor. Secondly, we already have another sub-page on the My Settings page, for OAuth, which is hidden away but still counts. So maybe we need:

* Account settings - (Display Name, Email Address, Password, External Authentication, Public editing, Contributor Terms, Go Public)
* Profile settings - (Profile description, avatar, home location)
* Preferences - (Preferred Language, Preferred Editor)
* OAuth Settings - no changes here, but maybe rename to Application Settings?

I also intend to rework viewing your own profile, to make it clearer what shows up for other people. The Users#show currently contains 20+ `if` statements since it's used for both public profiles and also showing extra things to yourself. A separate dashboard page for your own stuff would be more useful and understandable.

Before I try any of this out, I'm interested to hear what other people think, both about the underlying concept of splitting things up a bit, as well as the details of what could go where.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210407/f5afd45c/attachment-0001.htm>