[openstreetmap/openstreetmap-website] Add support for OAuth 2 (#3177)

Tom Hughes notifications at github.com
Wed Apr 14 21:37:48 UTC 2021


@tomhughes commented on this pull request.



> @@ -141,6 +141,10 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/oauth2_applications_controller.rb'

I tried that ;-) The problem is that just triggers a different rubocop warning:

```
app/controllers/oauth2_applications_controller.rb:14:3: W: [Correctable] Lint/UselessMethodDefinition: Useless method definition detected.
  def show ...
  ^^^^^^^^
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3177#discussion_r613603681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210414/8d01cdb2/attachment.htm>


More information about the rails-dev mailing list