[openstreetmap/openstreetmap-website] Fix broken `libpgosm.so` (#3286)

David Hummel notifications at github.com
Thu Aug 5 21:48:37 UTC 2021


After the removal of [db/functions/maptile.c](https://github.com/openstreetmap/openstreetmap-website/commit/4e6d729529c94486a50cf135dfbbdcf841790200#diff-c3f52ef93a4aaf1f148e626e39ec31e4de87ce44154fbb7f5ea6e321c4e195a4L34-L36) in 4e6d729529c94486a50cf135dfbbdcf841790200, the `PG_MODULE_MAGIC` macro no longer gets called and causes the compiled shared library to no longer function. Resolved by creating a new `.c`/`.o` file whose only function is to call `PG_MODULE_MAGIC`.

Also:
  * Added `libpgosm.so` build to `Test` workflow, here are links the relevant jobs:
    * Before:
      https://github.com/hummeltech/openstreetmap-website/runs/3256812366?check_suite_focus=true
    * After:
      https://github.com/hummeltech/openstreetmap-website/runs/3256813159?check_suite_focus=true
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3286

-- Commit Summary --

  * Fixing & testing `libpgosm.so` (Before)
  * Fixing & testing `libpgosm.so` (After)

-- File Changes --

    M .github/workflows/tests.yml (45)
    M db/functions/Makefile (2)
    A db/functions/pg_module_magic.c (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3286.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3286.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3286
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210805/39a4a107/attachment.htm>


More information about the rails-dev mailing list