[openstreetmap/openstreetmap-website] Refactor profile page and create a dashboard (#3297)
Andy Allan
notifications at github.com
Wed Aug 18 12:34:55 UTC 2021
The profile page was unusual for three main reasons:
* It was full-width, unlike any other non-map page
* The user's profile was put into the (grey) header, instead of being shown in the main part of the page
* The profile page added some not-really-related information when you viewed your own profile (like friendship activities) without any indication whether this information was public or not.
To resolve these three things I've refactored the profile page, so that it only shows the profile information and does so in the main content part instead of within the header. I've moved the other parts to a new Dashboard page, which I think in future can be expanded with more information that is useful for mappers to do their work.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3297
-- Commit Summary --
* Split the non-public information off of the profile page
* Refactor the profile page to move the profile information out of the header
-- File Changes --
M app/abilities/ability.rb (1)
M app/assets/stylesheets/common.scss (17)
A app/controllers/dashboards_controller.rb (14)
R app/views/dashboards/_contact.html.erb (4)
R app/views/dashboards/_popup.html.erb (0)
A app/views/dashboards/show.html.erb (61)
M app/views/layouts/_header.html.erb (1)
M app/views/users/show.html.erb (149)
M config/locales/en.yml (37)
M config/routes.rb (1)
A test/controllers/dashboards_controller_test.rb (34)
M test/controllers/users_controller_test.rb (10)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3297.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3297.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3297
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210818/924b11f8/attachment.htm>
More information about the rails-dev
mailing list