[openstreetmap/openstreetmap-website] Add Communities page (#3301)

Adam Hoyle notifications at github.com
Tue Aug 24 20:52:00 UTC 2021


Here's a draft PR for the Communities page as discussed on https://github.com/openstreetmap/openstreetmap-website/issues/3256

I would love to get any and all thoughts / questions / concerns - particularly on:
* how it's integrating with the `osm-community-index` data
* and also on how to handle the localisation (for this draft it's manually pulling it from the osm-community-index i18n files, but is this the best approach?)

Tests are still to come, but so any thoughts there are appreciated, but I'd like to make sure the approach is ok first.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3301

-- Commit Summary --

  * add route for communities
  * add communities page
  * stub model and show in view
  * add route to pass locale
  * add osm-community-index and parse in communities
  * render local chapters in html
  * tidy up / remove debug
  * improve link ordering
  * Merge branch 'master' into feature/add-communities-page
  * Localise local chapters
  * Update to latest osm-community-index
  * Tidy
  * Improve method privacy

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/controllers/site_controller.rb (5)
    A app/models/communities.rb (59)
    M app/views/layouts/_header.html.erb (4)
    A app/views/site/communities.html.erb (19)
    M config/locales/en.yml (25)
    M config/routes.rb (2)
    M package.json (1)
    M yarn.lock (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3301.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3301.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210824/0df57eac/attachment.htm>


More information about the rails-dev mailing list