[openstreetmap/openstreetmap-website] Post-merge Docker Compose cleanup issues (#3083)

Michal Migurski notifications at github.com
Thu Feb 4 17:13:32 UTC 2021


Follow up to Tom’s review comments in https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-582662631:

- Checkout was updated to v2 upstream, so no need to do that in this PR
- Bootsnap conditional in `config/boot.rb` appears to be necessary for this image to work under an Ubuntu image. Based on conversation in https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r549471542, I don’t think we can remove this
- Moved DB functions to `/usr/local/share/` since they’re still necessary per https://github.com/openstreetmap/openstreetmap-website/pull/2409#discussion_r570115583
- DB password and superuser privilege are both still needed when even when using trust auth because the database is needed for setup, migrations, normal usage, and data imports
- `yarnpkg install` is still required since `bundle exec` will not work without additional app code present during Docker build step. The old option here was to leave the yarn step for the end-user after app installation, but I think it’s better more of the build process to be automated within the Dockerfile

Closes https://github.com/openstreetmap/openstreetmap-website/issues/3081
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3083

-- Commit Summary --

  * Moved osm-db-functions.sql to /usr/local/share/
  * Added note about password and privileges for OSM DB user
  * Added explanatory notes and comments

-- File Changes --

    M DOCKER.md (1)
    M Dockerfile (7)
    M docker/postgres/Dockerfile (2)
    M docker/postgres/openstreetmap-postgres-init.sh (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3083.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3083.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3083
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210204/e80b6936/attachment.htm>


More information about the rails-dev mailing list