[openstreetmap/openstreetmap-website] Add Wiki link to header (#3086)

Andy Allan notifications at github.com
Wed Feb 17 10:17:14 UTC 2021


I'm going to close this PR since I've also closed the original issue. 

Just to help you with future PRs, I'll mention a couple of things that I noticed:

* This PR removed the Export link, without providing a replacement or explanation. I'm not sure if that was intended?
* The PR contains too many 'fixup' commits. In general PRs can contain multiple commits (and I prefer if they do) but each commit should be a logical group of work, rather than a blow-by-blow record of winning the battle with rubocop :-) My recommendation is to use a combination of `git rebase -i` (the 'fixup' option is great for combining such fixup commits into the original commit, and I use this every week)  and then force-push the branch to update the PR with your preferred list of commits.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3086#issuecomment-780452494
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210217/15192018/attachment.htm>


More information about the rails-dev mailing list