[openstreetmap/openstreetmap-website] Sync more hash-url-params for iD (#3032)

Tobias notifications at github.com
Sat Jan 2 19:53:57 UTC 2021


This commit includes a few console.logs since it is still WIP.

It solved part of the issue described in https://github.com/openstreetmap/openstreetmap-website/issues/3031:

Whenever I pan the map in iD, the osm-hash-params get updated with the current iD-in-iframe-configuration.
However, click actions in the iD iframe (eg changing the map layer) don't trigger this update until I also pan the map afterwards.

This is all I could contribute with my limited knowledge of the code. I am pretty sure there is a more elegant solution to this. However, I also think this would already be a bit better than what we have right now …
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3032

-- Commit Summary --

  * WIP: Sync more hash-url-params for iD

-- File Changes --

    M app/assets/javascripts/edit/id.js.erb (4)
    M app/assets/javascripts/id.js (31)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3032.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3032.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3032
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210102/f7ef33fd/attachment.htm>


More information about the rails-dev mailing list