[openstreetmap/openstreetmap-website] Traces: Migrate list to bootstrap (#3036)
Tobias
notifications at github.com
Sun Jan 3 21:18:15 UTC 2021
Changes:
- switch from tables to bootstrap media since it makes the spacing around the image easier and also its not a table in a semantic way
- remove the unless in #index since it is covered by the if-size>0 above
refactor the list
- reorder elements
- make the pending-image a blank square and move the pending notice to the first line
- move the actions to the right and use the previous title-text as link-text since those explain a lot better what the links actually do (I thought "edit" would edit the trace-db-entry, not open the map-editor)
- remove the two translations that are not used anymore from en.yml
- use if-present for tags-link-list since its easier to read
- use the same styling for the trace description as on the changeset description (italic text)
I will wait for a first review of this.
Still to do:
- [ ] Check specs
- [ ] Add translations for the two new strings (hint about how to this is welcome)
### Screenshots
BEFORE
<img width="875" alt="traces-before" src="https://user-images.githubusercontent.com/111561/103489011-7805f900-4e11-11eb-8d5f-7f8e745658a0.png">
AFTER
<img width="882" alt="traces-after" src="https://user-images.githubusercontent.com/111561/103489008-776d6280-4e11-11eb-8f76-daef52c9d348.png">
AFTER / PENDING
<img width="1133" alt="traces-pending" src="https://user-images.githubusercontent.com/111561/103489006-75a39f00-4e11-11eb-880f-cf0732160261.png">
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3036
-- Commit Summary --
* Traces: Migrate list to bootstrap
-- File Changes --
M app/views/traces/_trace.html.erb (72)
M app/views/traces/index.html.erb (8)
M config/locales/en.yml (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3036.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3036.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3036
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210103/42733a15/attachment-0001.htm>
More information about the rails-dev
mailing list