[openstreetmap/openstreetmap-website] Traces: Migrate pagination to bootstrap (#3035)

Andy Allan notifications at github.com
Wed Jan 6 15:53:53 UTC 2021


In general I would avoid the bootstrap spacer classes wherever possible. Since they are used here to "fight against" the CSS rule in common.css, my approach would be to rename that class to avoid clashing with bootstrap. But as far as I can tell we only use `.pagination` in two places, both of which you have refactored already, so I've removed it, along with the spacer classes added in this PR.

Refactoring to avoid `@variables` in partials is good to see too.

Thank you!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3035#issuecomment-755382269
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210106/115f9ab1/attachment.htm>


More information about the rails-dev mailing list