[openstreetmap/openstreetmap-website] Move banner close icon so we can see it (#3068)

Andy Allan notifications at github.com
Mon Jan 25 08:40:50 UTC 2021


> however, why not move the “x” and reduce the reserved space permanently? Seems like a good idea to have more space for banner content

But then it becomes inconsistent with the size and positioning of all the other X buttons on the sidebar, first-time visitor dialog, etc. We're doing a lot of work to remove the 2500+ lines of custom CSS that's full of inconsistencies like this! So I don't want to introduce more one-off positioning rules.

For accessibility reasons, we should move away from having banners with the text embossed into an image anyway, but that's a different topic.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3068#issuecomment-766650424
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210125/09212735/attachment.htm>


More information about the rails-dev mailing list