[openstreetmap/openstreetmap-website] Refactor account form to use bootstrap (#3074)

Andy Allan notifications at github.com
Wed Jan 27 18:05:17 UTC 2021


I've made this a separate PR since it's our biggest and most complex form.

There's definitely room for further refactoring, particularly around the image radio boxes and their names and values, but I didn't want to do too much at the same time.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3074

-- Commit Summary --

  * Use model attributes and attribute help for the registration fields
  * Refactor account form to use bootstrap

-- File Changes --

    M app/views/users/account.html.erb (206)
    M app/views/users/new.html.erb (6)
    M config/locales/en.yml (36)
    M test/controllers/users_controller_test.rb (40)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3074.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3074.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3074
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210127/13b3d1c4/attachment.htm>


More information about the rails-dev mailing list