[openstreetmap/openstreetmap-website] Link secondary WIkipedia tags - brand:wikipedia, operator:wikipedia, subject:wikipedia etc (#2184)
Minh Nguyễn
notifications at github.com
Fri Jul 2 17:38:26 UTC 2021
#788 added linking for `architect:wikidata`, `artist:wikidata`, `brand:wikidata`, `operator:wikidata`, and `subject:wikidata`. openstreetmap/openstreetmap-website at 36a382bb43c81847b9463066a57cc7986d7cd731 added linking for `name:etymology:wikidata` and `network:wikidata`. #2812 would add linking for `species:wikidata`.
At a glance, it looks like this case:
https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/helpers/browse_tags_helper.rb#L63-L64
needs to be consistent with this conditional:
https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/helpers/browse_tags_helper.rb#L107-L108
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2184#issuecomment-873156757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210702/6fcc31a3/attachment.htm>
More information about the rails-dev
mailing list