[openstreetmap/openstreetmap-website] Minor improvements to messages (#3258)

Andy Allan notifications at github.com
Wed Jul 14 17:58:13 UTC 2021


This PR contains a few minor improvements to the messages pages, namely

* Converting the inbox and outbox lines to tabs, in line with the tabs on the traces pages
* Adding a title to the header, since tabs alone looked a bit weird
* Putting the message title into the heading for sent messages, for consistency
* Making the delete message button red when viewing messages (for consistency with the similar buttons on inbox/outbox) and adding the button to the sent message view page (already shown on the outbox page)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3258

-- Commit Summary --

  * Convert mailbox navigation to use tabs
  * Add a title in the heading to match the main menu text
  * Ensure the message title shows in the heading for both sent and received messages
  * Ensure message destroy button has danger colour when showing the message, and add button to show page when viewing sent messages

-- File Changes --

    M app/views/messages/inbox.html.erb (5)
    M app/views/messages/outbox.html.erb (6)
    M app/views/messages/show.html.erb (18)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3258.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3258.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210714/12ebab5a/attachment.htm>


More information about the rails-dev mailing list