[openstreetmap/openstreetmap-website] Separate forms for preferences and profile (#3257)

Andy Allan notifications at github.com
Wed Jul 21 10:04:51 UTC 2021


@gravitystorm commented on this pull request.



> @@ -165,6 +165,12 @@
 
     <div class="user-description richtext text-break"><%= @user.description.to_html %></div>
 
+    <% if current_user and @user.id == current_user.id %>
+      <div class="my-3">
+        <%= link_to t(".edit_profile"), edit_profile_path, :class => "btn btn-outline-primary" %>

I can move it around, but to be fair I think the whole page is already a mess. My plan is a followup PR that 

* Moves the profile content out of the (grey) page header and into the main part of the page
* Remove the strange override that makes the profile page the only edge-to-edge page
* Moves the admin stuff into the header along with the rest of the stuff that's there already
* Moves the non-profile stuff (like lists of friends, links that aren't shown to other people etc) off that page and into a separate dashboard

I think at that point the edit button will sit more naturally under the profile content.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3257#discussion_r673838380
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210721/42f65da5/attachment.htm>


More information about the rails-dev mailing list