[openstreetmap/openstreetmap-website] Switch to html5-compatible fragment encoding for wikipedia URLs (#3278)
Andy Allan
notifications at github.com
Wed Jul 28 15:03:18 UTC 2021
Fixes #3269
In the HTML4 days, fragments weren't allowed to have `%` signs, so mediawiki generated fragments with `%` replaced with a `.`
In HTML5, fragments can have % encoded characters, and so in 2017 wikipedia switched over to this for their automatically generated fragments, while keeping the "dot" versions available as a fallback.
However, we have been automatically converting all fragments, including manually specified anchors that do not have "dot"-encoded versions available. So we can now simplify everything by just using the HTML5 percent-encoded fragments.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3278
-- Commit Summary --
* Switch to html5-compatible fragment encoding for wikipedia URLs
-- File Changes --
M app/helpers/browse_tags_helper.rb (2)
M test/helpers/browse_tags_helper_test.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3278.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3278.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3278
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210728/4dc2228d/attachment.htm>
More information about the rails-dev
mailing list