[openstreetmap/openstreetmap-website] Some things you do with issues do not actually update the updated_* fields (#3211)
Frederik Ramm
notifications at github.com
Fri Jun 4 14:28:16 UTC 2021
The "issue" object has an "updated_at" field and an "updated_by" field. These should ideally be changed at the same time, whenever an issue is modified in any way, including when it attracts new reports or new comments.
Instead:
* when an issue is ignored https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/controllers/issues_controller.rb#L62 or reopened https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/controllers/issues_controller.rb#L72 this works correctly.
* when an issue is resolved https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/controllers/issues_controller.rb#L51 then the updated_at changes, but the updated_by does not.
* when a comment is added to it https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/controllers/issue_comments_controller.rb#L9-L17 then neither the updated_at changes nor the updated_by.
* when a new report comes in for an existing issue, then I *think* the updated_at gets changed but not the updated_by (not sure).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3211
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210604/d1b5c14b/attachment.htm>
More information about the rails-dev
mailing list