[openstreetmap/openstreetmap-website] Spelling (#3233)

Fri Jun 25 04:48:30 UTC 2021

@jsoref commented on this pull request.

> @@ -17,7 +17,7 @@ class ApplicationController < ActionController::Base

   helper_method :current_user
   helper_method :oauth_token
-  helper_method :preferred_langauges
+  helper_method :preferred_languages

?

> @@ -4,7 +4,7 @@
     <div class='userinformation-inner'>
       <h1><%= @user.display_name %> <%= role_icons(@user) %></h1>
       <% if current_user and @user.id == current_user.id %>
-        <!-- Displaying user's own profile page to themself -->
+        <!-- Displaying user's own profile page -->

`themself` is considered archaic. In order for it to be `user's own`, the observer has to be the user...

> @@ -681,7 +681,7 @@ en:
           houseboat: "Houseboat"
           hut: "Hut"
           industrial: "Industrial Building"
-          kindergarten: "Kindergarden Building"
+          kindergarten: "Kindergarten Building"

?

> @@ -706,7 +706,7 @@ en:
           sport: "Sportsclub"
           "yes": "Club"
         craft:
-          beekeper: "Beekeeper"
+          beekeeper: "Beekeeper"

?

Is this an api?

> @@ -736,7 +736,7 @@ en:
           ambulance_station: "Ambulance Station"
           assembly_point: "Assembly Point"
           defibrillator: "Defibrillator"
-          fire_xtinguisher: "Fire Extinguisher"
+          fire_extinguisher: "Fire Extinguisher"

?

Is this an api?

> @@ -2346,7 +2346,7 @@ de:
     bridge: DE:Key:bridge
     bridge:movable: DE:Key:bridge:movable
     bridge:structure: DE:Key:bridge:structure
-    buiding: DE:Key:buiding
+    building: DE:Key:building

?

Is this an api? (this would be wrong, since it'll collide w/ `building` below:

> @@ -5552,7 +5552,7 @@ en:
     hazard: Key:hazard
     hazard:animal: Key:hazard:animal
     hazard_intensity: Key:hazard intensity
-    hazard_occurence: Key:hazard occurence
+    hazard_occurrence: Key:hazard occurrence

?

Is this an api?

> @@ -5745,7 +5745,7 @@ en:
     light_rail: Key:light rail
     lighting:perceived: Key:lighting:perceived
     line: Key:line
-    line_attachement: Key:line attachement
+    line_attachment: Key:line attachment

?

Is this an api?

> @@ -7568,7 +7568,7 @@ en:
     amenity=winery: Tag:amenity=winery
     amenity=yacht_club: Tag:amenity=yacht club
     amenity=youth_centre: Tag:amenity=youth centre
-    aminety=sceptic_tank: Tag:aminety=sceptic tank
+    amenity=sceptic_tank: Tag:amenity=sceptic tank

?

Is this an api?

> @@ -7649,7 +7649,7 @@ en:
     barrier=retaining_wall: Tag:barrier=retaining wall
     barrier=rope: Tag:barrier=rope
     barrier=sally_port: Tag:barrier=sally port
-    barrier=select_acces: Tag:barrier=select acces
+    barrier=select_access: Tag:barrier=select access

?

Is this an api?

> @@ -8050,7 +8050,7 @@ en:
     crane:type=portal_crane: Tag:crane:type=portal crane
     crane:type=travel_lift: Tag:crane:type=travel lift
     crop=asparagus: Tag:crop=asparagus
-    crop=aspargus: Tag:crop=aspargus
+    crop=asparagus: Tag:crop=asparagus

?

Is this an api?

> @@ -8180,7 +8180,7 @@ en:
     emergency=ambulance_station: Tag:emergency=ambulance station
     emergency=assembly_point: Tag:emergency=assembly point
     emergency=coast_guard: Tag:emergency=coast guard
-    emergency=defibrilator: Tag:emergency=defibrilator
+    emergency=defibrillator: Tag:emergency=defibrillator

?

Is this an api?

> @@ -9861,7 +9861,7 @@ en:
     seamark:buoy_special_purpose:shape=super-buoy: Tag:seamark:buoy special purpose:shape=super-buoy
     seamark:cable_overhead:category=power: Tag:seamark:cable overhead:category=power
     seamark:cable_overhead:category=telephone: Tag:seamark:cable overhead:category=telephone
-    seamark:conspicuity=conspicious: Tag:seamark:conspicuity=conspicious
+    seamark:conspicuity=conspicuous: Tag:seamark:conspicuity=conspicuous

?

Is this an api?

> @@ -10488,7 +10488,7 @@ en:
     sport=batting_cage: Tag:sport=batting cage
     sport=beachvolleyball: Tag:sport=beachvolleyball
     sport=biathlon: Tag:sport=biathlon
-    sport=billards: Tag:sport=billards
+    sport=billiards: Tag:sport=billiards

?

Is this an api?

> @@ -10948,7 +10948,7 @@ en:
     vending=books: Tag:vending=books
     vending=bottle_return: Tag:vending=bottle return
     vending=bread: Tag:vending=bread
-    vending=bycicle_tube: Tag:vending=bycicle tube
+    vending=bicycle_tube: Tag:vending=bicycle tube

?

Is this an api?

> @@ -13235,7 +13235,7 @@ fr:
     barrier=retaining_wall: FR:Tag:barrier=retaining wall
     barrier=rope: FR:Tag:barrier=rope
     barrier=sally_port: FR:Tag:barrier=sally port
-    barrier=select_acces: FR:Tag:barrier=select acces
+    barrier=select_access: FR:Tag:barrier=select access

?

Is this an api?

> @@ -19592,7 +19592,7 @@ pt-br:
     craft=tiler: Pt-br:Tag:craft=tiler
     craft=tinsmith: Pt-br:Tag:craft=tinsmith
     craft=upholsterer: Pt-br:Tag:craft=upholsterer
-    craft=upholstrer: Pt-br:Tag:craft=upholstrer
+    craft=upholsterer: Pt-br:Tag:craft=upholsterer

?

Is this an api?

> @@ -474,7 +474,7 @@ def self.parse_float(str, klass, *args)

   # Construct a random token of a given length
   def self.make_token(length = 30)
-    chars = "abcdefghijklmnopqrtuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
+    chars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"

What happened to `s`?

> @@ -1326,7 +1326,7 @@ def test_josm_upload
           <node id='-7' visible='true' changeset='#{changeset_id}' lat='51.49560784152179' lon='-0.18694719410005425' />
           <node id='-8' visible='true' changeset='#{changeset_id}' lat='51.49567389979617' lon='-0.1860289771788006' />
           <node id='-9' visible='true' changeset='#{changeset_id}' lat='51.49543761398892' lon='-0.186820684213126' />
-          <way id='-10' action='modiy' visible='true' changeset='#{changeset_id}'>
+          <way id='-10' action='modify' visible='true' changeset='#{changeset_id}'>

?

Is this an api?

> @@ -13,7 +13,7 @@ def setup
       @goodbbox = %w[-0.1,-0.1,0.1,0.1 51.1,-0.1,51.2,0
                      -0.1,%20-0.1,%200.1,%200.1 -0.1edcd,-0.1d,0.1,0.1 -0.1E,-0.1E,0.1S,0.1N S0.1,W0.1,N0.1,E0.1]
       # That last item in the goodbbox really shouldn't be there, as the API should
-      # reall reject it, however this is to test to see if the api changes.
+      # really reject it, however this is to test to see if the api changes.

probably

> @@ -86,7 +86,7 @@ def test_create
     end

     def test_create_invalid_xml
-      ## Only test public user here, as test_create should cover what's the forbiddens
+      ## Only test public user here, as test_create should cover what's the forbidden

this doesn't make sense even after this change

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3233#pullrequestreview-692444297
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210624/e1624a94/attachment-0001.htm>