[openstreetmap/openstreetmap-website] Spelling (#3233)

Andy Allan notifications at github.com
Fri Jun 25 08:23:40 UTC 2021


Thanks for the PR! Unfortunately it contains a bit of a grab-bag of unrelated changes, which makes it much harder to review and discuss. So I have a few suggestions:

* Remove any changes that affect the config/wiki_pages.yml file. This is an autogenerated file (as it says at the top of the file), so changes here aren't appropriate
* As far as I can see, the changes to code comments are fine (and low risk) so could be moved to a separate PR for easier review
* changes to code (e.g. helper methods) need a lot more careful scrutiny so it would be best to deal with them on a more focussed PR


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3233#issuecomment-868317746
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210625/87581098/attachment.htm>


More information about the rails-dev mailing list