[openstreetmap/openstreetmap-website] Go button collapses wrongly at medium width (#3119)

Andy Allan notifications at github.com
Thu Mar 4 13:12:40 UTC 2021


On my screen, it's between 653 and 768px. But it depends on the size of your menus (e.g. length of username) whether you see the bug at all. From the smallest width, it happens from the `small-nav / compact-nav` cutover, up until the sidebar becomes full width (at 768px). You might not see it if your own `small-nav / compact-nav` cutover is above 768 px (e.g. you have a long username, many unread messages, or something like that).

Less than 768px screen width, the sidebar is 300px:

https://github.com/openstreetmap/openstreetmap-website/blob/dfeb93c9f8e39323d72c147dc80b6c28971026b8/app/assets/stylesheets/small.scss#L110

Greater than 768px screen width, the sidebar is 350px:

https://github.com/openstreetmap/openstreetmap-website/blob/1c2d0ba92d4fad53b3abb09b90c72a00a018f0db/app/assets/stylesheets/common.scss#L358

In all honesty I'm not sure we need the two-stage sidebar width change, and it's not something that I've been conscious of before. It changes from 300 to 350px which isn't all that significant. So I might remove this 'narrower sidebar' changeover at some point too. I also think the presence of the sidebar should be based on screen width rather than the menu width, but that's further work!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3119#issuecomment-790607995
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210304/918d8ce5/attachment.htm>


More information about the rails-dev mailing list