[openstreetmap/openstreetmap-website] Prevent flash messages from expanding offscreen (PR #3380)

Andy Allan notifications at github.com
Wed Nov 24 14:34:04 UTC 2021


Because we are using an edge-to-edge layout for the flash messages, the negative margins on the row were expanding the element offscreen.

Bootstrap provides a "no-gutter" class for removing these margins, but that also drops the spacing between columns which we want to preserve. So instead we use a margin override on the row only.

Additionally, drop some padding css in favour of a utility class

Fixes #3351

Bug was introduced in 3dd639c8d02677b773935aa982ba0c9f3cc209e5
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3380

-- Commit Summary --

  * Prevent flash messages from expanding offscreen

-- File Changes --

    M app/assets/stylesheets/common.scss (2)
    M app/views/layouts/_flash.html.erb (6)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3380.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3380.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3380
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20211124/c382c1ab/attachment.htm>


More information about the rails-dev mailing list