[openstreetmap/openstreetmap-website] google imagery blacklist entry update (PR #3512)

[Andy Allan]

So I'm happy to merge this, but I would like to revisit some of the conversation in https://github.com/openstreetmap/openstreetmap-website/pull/1267 , namely

> If we were happy to only match the domain before then why not stick with that but broaden the domain match? Why start trying to (badly) match the rest of the URL as well, which just means it will break every time google tweak their URLs... 

The currently proposed regex is even more complex than the complex one we had already. So in my view we should choose between these:

* If we're trying to stop everything from the google/googleapis domains, then we don't need the complexity in the path matching. 
* If we're trying to block the paths selectively, while permitting certain other paths to continue to work, then we need to add unit tests to a) illustrate which paths are supported and b) ensure these continue to work when the regex is next refactored.

I suspect we can just block all paths though, and therefore simplify the regex substantially. Thoughts?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3512#issuecomment-1090472903
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3512/c1090472903 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220406/f313d868/attachment.htm>