[openstreetmap/openstreetmap-website] Rubocop autofix: ambiguous operator precedence (PR #3523)

[Tom Hughes]

I think I misread some of the changes the other day - it doesn't actually bracket chains of identical ops as I suggested.

I have to disagree about the readability though - the huge numbers of parentheses actually slows me down when I try and read those expressions as I have to parse them all and try and understand what they're doing and where the matching open is when you get three or four closes in a row only to find it doesn't really do anything.

That may be me though - because I'm not used to using them in basic arithmetic expressions when I do see them I assume something unusual is going on and start trying to understand how the default precedence is being overridden.

Mostly I just find the results ugly though so I guess I don't really have a good argument for not doing it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3523#issuecomment-1094290411
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3523/c1094290411 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220410/6e9ea7ef/attachment.htm>