[openstreetmap/openstreetmap-website] Meaningful and disambiguating class/type labels (from 2012) (PR #3536)

[Andy Allan]

@gravitystorm requested changes on this pull request.

I'm generally happy with the PR, and neutral on most of the changes, but I've flagged a few that need further attention.

> @@ -661,12 +661,12 @@ en:
           driving_school: "Driving School"
           embassy: "Embassy"
           events_venue: "Events Venue"
-          fast_food: "Fast Food"
+          fast_food: "Fast Food Restaurant"

This should be removed, since amenity=fast_food also covers food trucks and takeaway only outlets.

> @@ -841,7 +841,7 @@ en:
           bridleway: "Bridleway"
           bus_guideway: "Guided Bus Lane"
           bus_stop: "Bus Stop"
-          construction: "Highway under Construction"
+          construction: "Road under Construction"

highway=construction also applies to paths, steps and other non-road things. I know that "highway" has a general meaning too, outside of OSM, that doesn't exactly match what we mean within OSM, but the simplest way forward is to keep the "highway" terminology here since it's accurate within the OSM context.

> @@ -931,9 +931,9 @@ en:
           brownfield: "Brownfield Land"
           cemetery: "Cemetery"
           commercial: "Commercial Area"
-          conservation: "Conservation"
-          construction: "Construction"
-          farm: "Farm"
+          conservation: "Conservation Area"
+          construction: "Construction Area"
+          farm: "Farmland"

This key is deprecated and should be removed rather than changed. There's only a few instances of it remaining in the database in 2022 anyway.

> @@ -1228,8 +1228,8 @@ en:
           deli: "Deli"
           department_store: "Department Store"
           discount: "Discount Items Shop"
-          doityourself: "Do-It-Yourself"
-          dry_cleaning: "Dry Cleaning"
+          doityourself: "Do-It-Yourself Shop"
+          dry_cleaning: "Dry Cleaner"

The "Dry cleaning" term is the one exclusively used in the OSM wiki, so I think it's fine to keep the original

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3536#pullrequestreview-954898791
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3536/review/954898791 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220427/693cbdad/attachment-0001.htm>