[openstreetmap/openstreetmap-website] Diary comment "save" text misleading (Issue #3650)

[Andy Allan]

By default Rails will create appropriate text for submission buttons, based on the model, e.g. "Create Diary Comment". When they aren't suitable we can easily override these in the "en.helpers.submit" section of the translations file:

https://github.com/openstreetmap/openstreetmap-website/blob/d3388abe51a946ae0abc645d831a93b1b2cc6749/config/locales/en.yml#L11-L35

There's also a few other overrides that, for unimportant reasons, appear elsewhere in the file, e.g. Changeset Comments:

https://github.com/openstreetmap/openstreetmap-website/blob/d3388abe51a946ae0abc645d831a93b1b2cc6749/config/locales/en.yml#L2869

For comment submit buttons we currently have:

* "Comment" (Changeset Comments)
* "Add Comment" (Issue Comments)
* "Comment" (Note Comments)
* "Save" (Diary Comments)

I agree "Save" isn't a good term to use. I don't think it necessarily needs to be consistent with new Diary Entries though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3650#issuecomment-1205080733
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/3650/1205080733 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220804/0ed67007/attachment.htm>