[openstreetmap/openstreetmap-website] Position close buttons with flexbox (PR #3666)

[Anton Khorev]

Implemented this:

> https://github.com/openstreetmap/openstreetmap-website/pull/3631#issuecomment-1203797930
> Many of the close buttons https://github.com/openstreetmap/openstreetmap-website/pull/2901 recently to use flexbox for layout, rather than floating, but there's still some (as found in this PR) where the icons are floating around. These could be refactored to follow the convention used in the sidebar.

Also refactored common code in Leaflet sidebars that wrote close buttons among other things.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3666

-- Commit Summary --

  * Create Leaflet sidebar pane control with header writer fn
  * Create pane button fn
  * Inverted onAdd() method of sidebar panes
  * Position Leaflet sidebar close buttons with flex
  * Remove unnecessary float from flex-positioned close button
  * Position 'too many features' close button with flex
  * Position directions close button with flex
  * Fix eslint errors

-- File Changes --

    M app/assets/javascripts/index.js (1)
    M app/assets/javascripts/index/browse.js (29)
    M app/assets/javascripts/index/directions.js (29)
    M app/assets/javascripts/leaflet.key.js (41)
    M app/assets/javascripts/leaflet.layers.js (40)
    M app/assets/javascripts/leaflet.share.js (51)
    A app/assets/javascripts/leaflet.sidebar-pane.js (53)
    M app/views/application/_sidebar_header.html.erb (2)
    M app/views/layouts/_search.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3666.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3666.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3666
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3666 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220827/8ff7cded/attachment.htm>