[openstreetmap/openstreetmap-website] Imagery blacklist blocks Google Cloud Storage hosted imagery (Issue #3591)

[Andy Allan]

> As for the regexps, I haven't yet had a chance to investigate any of the implications mentioned above, so I can't answer which direction for a solution that I would prefer, yet.

OK, I've had a look through the related issues and thanks @pnorman for the additional information. 

I don't have a preferred solution, since I'm not a regexp expert. So I'll outline the constraints, and then I'm happy to review any PR that meets those constraints. But please, realise that there's never a guarantee that any specific PR will be accepted, so please no complaining if a proposed PR is declined and also please no complaining if it takes a while for any PR to be reviewed.

* I'm happy to allow user-hosted imagery on google cloud storage. The purpose of the blacklist isn't to prevent this.
* The regular expressions should not rely on "negative lookbehinds" or other features that are not cross-browser or not well supported in most programming languages. I'll defer to other people's knowledge on this topic, if required. This is because our API is implementation-agnostic so "it works in JOSM" or "it works in iD in some browsers" is not sufficient.
* The PR must come with tests for the regular expressions demonstrating sample urls that should be blocked and sample urls that should be permitted.
* There must be tests to show that it continues to block google map images and google aerial imagery.
* There must be tests to show that user-hosted imagery on google cloud storage is permitted.
* There must be some narrative explanation as to why google are unlikely to use google cloud storage for their own maps and/or imagery, either now or in the near term, since I don't want to end up having some kind of per-bucket blacklist or whitelist if they start hosting their own maps/imagery on the storage.googleapis.com domain too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3591#issuecomment-1233022135
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/3591/1233022135 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220831/994413e5/attachment.htm>