[openstreetmap/openstreetmap-website] Remove geolink and close button nesting (PR #3672)
Anton Khorev
notifications at github.com
Wed Aug 31 21:51:24 UTC 2022
Fixes buttons within geolinks issue: https://github.com/openstreetmap/openstreetmap-website/pull/3631#issuecomment-1203797930
For the directions sidebar I removed the geolink because its close button had its own click handler that prevented default actions.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3672
-- Commit Summary --
* Remove geolink and close button nesting
-- File Changes --
M app/assets/javascripts/index/directions.js (8)
M app/views/application/_sidebar_header.html.erb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3672.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3672.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3672
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3672 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220831/d202d2a9/attachment.htm>
More information about the rails-dev
mailing list