[openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

[Andy Allan]

I just want to say here thanks to @pnorman and @mmd-osm for their reviews over the last few weeks, I've found them very helpful. In particular it's helpful to know when a PR might have been overlooked and is otherwise straightforward to review or ready for merging.

> I don't believe reviewing random pull requests is an effective way going forward. I doubt it will add much value, even worse it might only add more noise without getting anything done in the end.

Well, I disagree with you there! It does add value, since I think you have good judgement. But more importantly, you often highlight things that need dealing with or look at something from an angle that the OP might not have considered. So I don't think you would be just adding more noise.

> Then tell everyone, hey, this is what I'd like to work on, please help reviewing, add your comments.

I think this sentence is directed at the maintainers, as opposed to the OPs, right? As in you think a maintainer could shortlist one or more PRs for closer inspection, we all then focus on just those PRs? It's an interesting idea, and not an approach that I've considered before, so I'll have a think about it. My first concern is that it treads close to asking volunteers to do work that they aren't interested in. For example, if a reviewer normally concentrates on javascript stuff, and I don't put any javascript-related PRs on the shortlist, could they then be discouraged from participating for those three weeks?

Hopefully we'll reduce the number of PRs in the backlog where such shortlisting and planning overhead wouldn't be necessary. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-1341584674
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/3815/1341584674 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221207/d4488f03/attachment-0001.htm>