[openstreetmap/openstreetmap-website] Don't add title to note marker if note has no visible comments (PR #3617)

Anton Khorev notifications at github.com
Thu Dec 8 10:47:40 UTC 2022


> Why are there even notes available with no visible comments?

There are notes without comments mainly from deleted users. These notes are available because the API makes them available. It's not my decision that these notes should be available from the API. It's not my decision that comments of deleted users should be hidden.

This PR is a fix for a bug. You can decide:

- to keep the bug
- to fix the bug by not trying to display the comment when it doesn't exist - that's what this PR does
- to fix the bug by not displaying the note marker when no comments exist
- change the API

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3617#issuecomment-1342516146
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3617/c1342516146 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221208/06110fc3/attachment.htm>


More information about the rails-dev mailing list