[openstreetmap/openstreetmap-website] Make max_id part of url path on history pages (PR #3834)

Anton Khorev notifications at github.com
Thu Dec 8 14:07:26 UTC 2022


Smaller change from https://github.com/openstreetmap/openstreetmap-website/pull/3829. 

Enables links like `/user/username/history/123` where `123` is treated like `max_id` parameter. Since those links are not yet used anywhere, there are no changes that are noticeable during normal website use.

Originally I didn't want to make this url change along with https://github.com/openstreetmap/openstreetmap-website/pull/3829 but it turned out that it was easier to do it rather than to work with `?max_id=123` parameters.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3834

-- Commit Summary --

  * Make max_id part of url path on history pages

-- File Changes --

    M app/assets/javascripts/index.js (8)
    M config/routes.rb (8)
    M test/controllers/changesets_controller_test.rb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3834.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3834.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3834
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3834 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221208/1d031018/attachment.htm>


More information about the rails-dev mailing list