[openstreetmap/openstreetmap-website] Wait for the button to be disabled, before checking the tooltip (PR #3853)

Andy Allan notifications at github.com
Wed Dec 21 16:44:30 UTC 2022


Rather than sleeping for a fixed period, we can use Capybara's built-in ability to wait for elements to be present. Since we're only changing the state of existing elements though, we need to wait for their "disabled" property to be set.

Fixes some timing-related problems with the test suite.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3853

-- Commit Summary --

  * Wait for the button to be disabled, before checking the tooltip behaviour

-- File Changes --

    M test/system/site_test.rb (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3853.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3853.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3853
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3853 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221221/81898767/attachment-0001.htm>


More information about the rails-dev mailing list