[openstreetmap/openstreetmap-website] Quote ruby versions in yaml (PR #3860)

Andy Allan notifications at github.com
Wed Dec 28 10:11:01 UTC 2022


Without quotes these are parsed as numbers, which can cause subtle problems. For example, "ruby: 3.0" is interpreted by the ruby/setup-ruby action as "ruby: 3", meaning 3.x instead of the intended 3.0.x

The test suite started failing a couple of days ago, with an error installing nokogiri - this is because nokogiri doesn't support ruby 3.2 yet, we were inadvertently installing "ruby: 3" instead of "ruby: '3.0'", and then when setup/ruby was updated a couple of days ago to support 3.2 this bug was unveiled.

It also means we haven't actually been testing on ruby 3.0.x since ruby 3.1 was released - our tests were just running twice on ruby 3.1 :smile:
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3860

-- Commit Summary --

  * Quote ruby versions in yaml

-- File Changes --

    M .github/workflows/lint.yml (2)
    M .github/workflows/tests.yml (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3860.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3860.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3860
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3860 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221228/0c33b5a0/attachment.htm>


More information about the rails-dev mailing list