[openstreetmap/openstreetmap-website] Update to rails 7.x (PR #3414)
Andy Allan
notifications at github.com
Wed Feb 16 14:09:20 UTC 2022
@gravitystorm approved this pull request.
Aside from the annotate models thing, everything else looks good to me. I've tested it locally and I get a few deprecation warnings but we can fix them later.
> @@ -1,7 +1,7 @@
# NOTE: only doing this in development as some production environments (Heroku)
# NOTE: are sensitive to local FS writes, and besides -- it's just not proper
# NOTE: to have a dev-mode tool do its thing in production.
-if Rails.env.development?
I don't think we need this change now that annotate_models is working again
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3414#pullrequestreview-884591815
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3414/review/884591815 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220216/e421cd76/attachment.htm>
More information about the rails-dev
mailing list