[openstreetmap/openstreetmap-website] google imagery blacklist entry update (PR #3512)
hlfan
notifications at github.com
Sun Jul 10 15:40:53 UTC 2022
So reassessment time it is!
As @gravitystorm noted, a unit test for specificly allowing the [storage.google.com subdomain](https://www.osm.org/id#background=custom:https://storage.googleapis.com/soi_data/export/tiles/{z}/{x}/{y}.webp&map=6/22/80) is needed.
A negative lookaround in `.*(?<!storage)\.google(apis)?\..*/.*` seems to allow that.
That said, [Safari (and IE) doesn't support lookbehinds yet](https://caniuse.com/js-regexp-lookbehind).
Assuming this regex works for most OSM-contributers needing this exeption and there isn't a less complex option I'm missing, the regex above should do it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3512#issuecomment-1179751097
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3512/c1179751097 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220710/7f5b5c0d/attachment.htm>
More information about the rails-dev
mailing list