[openstreetmap/openstreetmap-website] Upgrade to Bootstrap v5 (PR #3610)

[Andy Allan]

This PR upgrades Bootstrap to v5, specifically [v5.1](https://getbootstrap.com/docs/5.1/getting-started/introduction/), and therefore fixes https://github.com/openstreetmap/openstreetmap-website/issues/3230

There's a lot of changes in the v4 to v5 upgrade, but I've gone through everything in the [changelog](https://getbootstrap.com/docs/5.1/migration/), and made each change a separate commit, and so hopefully everything is dealt with. If anyone spots any glitches in our use of v5, I'm happy to fix them.

There are very few noticeable visual changes. #3609 is a prerequisite for this PR, or can be merged along with this. One visible change is that RFS is enabled in v5, and I'm fine with that. The menu dropdown widths in RTL are now fixed (see #2527) but other problems (e.g. button-group rounding) are not fixed yet without further work.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3610

-- Commit Summary --

  * Upgrade to bootstrap 5
  * Bootstrap 5: change rounded-sm to rounded-1
  * Bootstrap 5: Enable negative margins
  * Bootstrap 5: Remove use of form-row class
  * Bootstrap 5: Update manual select boxes to use form-select class
  * Bootstrap 5: Override float attribute on legends
  * Bootstrap 5: Add form-label class to hand-crafted form labels
  * Bootstrap 5: Replace all form-group classes with mb-3
  * Bootstrap 5: Replace card-deck with a row-cols-* based grid
  * Bootstrap 5: no-gutters renamed to g-0
  * Bootstrap 5: data-toggle renamed to data-bs-toggle for dropdown menus
  * Use bootstrap variables to style links
  * Bootstrap 5: Override button text colours, force to white
  * Bootstrap 5: Remove the padding from trace nav buttons on larger sizes

-- File Changes --

    M Gemfile (4)
    M Gemfile.lock (12)
    M app/assets/javascripts/leaflet.share.js (4)
    M app/assets/stylesheets/common.scss (35)
    M app/assets/stylesheets/parameters.scss (7)
    M app/views/accounts/edit.html.erb (14)
    M app/views/browse/changeset.html.erb (2)
    M app/views/browse/new_note.html.erb (2)
    M app/views/browse/note.html.erb (2)
    M app/views/dashboards/_popup.html.erb (2)
    M app/views/diary_entries/_form.html.erb (2)
    M app/views/issues/index.html.erb (18)
    M app/views/layouts/_header.html.erb (8)
    M app/views/layouts/_search.html.erb (12)
    M app/views/oauth2_authorizations/new.html.erb (2)
    M app/views/oauth_clients/_form.html.erb (2)
    M app/views/profiles/edit.html.erb (6)
    M app/views/sessions/new.html.erb (8)
    M app/views/shared/_richtext_field.html.erb (2)
    M app/views/site/export.html.erb (2)
    M app/views/site/help.html.erb (14)
    M app/views/traces/index.html.erb (2)
    M app/views/user_blocks/edit.html.erb (6)
    M app/views/user_blocks/new.html.erb (6)
    M app/views/user_blocks/revoke.html.erb (2)
    M app/views/users/new.html.erb (6)
    M app/views/users/terms.html.erb (12)
    M test/controllers/accounts_controller_test.rb (12)
    M test/controllers/preferences_controller_test.rb (2)
    M test/controllers/profiles_controller_test.rb (8)
    M test/controllers/users_controller_test.rb (10)
    M test/integration/user_creation_test.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3610.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3610.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3610
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3610 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220720/9b1c37a2/attachment-0001.htm>