[openstreetmap/openstreetmap-website] Add a locale selector (PR #3618)
Tom Hughes
notifications at github.com
Sun Jul 24 11:18:07 UTC 2022
In light of https://www.openstreetmap.org/user/TrickyFoxy/diary/399621 I have resurrected my locale selector branch from many years ago that attempted to address #1115.
The rebased and updated version is running at https://locale.apis.dev.openstreetmap.org/ as it has been for the last N years...
Outstanding issues that we need to think about before we can consider merging this:
* Where exactly to put the trigger control and how to present it - currently I have it showing the language code to save space while Wikimedia normally show the full language name.
* What should take priority for logged in users? or maybe we just hide the control for logged in users?
* Do we need a way to clear the override (other that restarting browser, which loses the session cookie) or not? Possibly if we ignore the cookie and hide the control for logged in users then we don't?
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3618
-- Commit Summary --
* Add a locale selector
-- File Changes --
M .rubocop_todo.yml (4)
M Vendorfile (8)
M app/assets/javascripts/application.js (1)
M app/assets/javascripts/osm.js.erb (1)
A app/assets/javascripts/uls.js (30)
M app/assets/stylesheets/screen-ltr.css (1)
M app/assets/stylesheets/screen-rtl.css (1)
A app/assets/stylesheets/uls.scss (42)
M app/controllers/application_controller.rb (2)
M app/controllers/users_controller.rb (6)
M app/views/layouts/_header.html.erb (2)
A vendor/assets/jquery.uls/css/jquery.uls.css (119)
A vendor/assets/jquery.uls/css/jquery.uls.grid.css (307)
A vendor/assets/jquery.uls/css/jquery.uls.lcd.css (140)
A vendor/assets/jquery.uls/css/jquery.uls.mobile.css (307)
A vendor/assets/jquery.uls/images/close.svg (8)
A vendor/assets/jquery.uls/images/language.svg (7)
A vendor/assets/jquery.uls/images/search.svg (7)
A vendor/assets/jquery.uls/src/jquery.uls.core.js (499)
A vendor/assets/jquery.uls/src/jquery.uls.data.js (6412)
A vendor/assets/jquery.uls/src/jquery.uls.data.utils.js (335)
A vendor/assets/jquery.uls/src/jquery.uls.languagefilter.js (361)
A vendor/assets/jquery.uls/src/jquery.uls.lcd.js (481)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3618.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3618.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3618
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3618 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220724/b5db3264/attachment.htm>
More information about the rails-dev
mailing list